Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/19657#discussion_r149174223 --- Diff: R/pkg/R/install.R --- @@ -152,6 +152,9 @@ install.spark <- function(hadoopVersion = "2.7", mirrorUrl = NULL, }) if (!tarExists || overwrite || !success) { unlink(packageLocalPath) + if (success) { --- End diff -- Hmm ok that still looks weird in the code. Maybe add a comment before this of the form `If we downloaded a tarfile or overwrote it, set sparkDownloaded flag` ?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org