Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19657#discussion_r149017035
--- Diff: R/pkg/R/install.R ---
@@ -152,6 +152,9 @@ install.spark <- function(hadoopVersion = "2.7",
mirrorUrl = NULL,
})
if (!tarExists || overwrite || !success) {
unlink(packageLocalPath)
+ if (success) {
--- End diff --
basically if `success` is TRUE then only the other cases matter:
`!tarExists || overwrite` - that's the exact condition where the download would
have occurred in L126 which is the else case of `tarExists && !overwrite` on
L123
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
