Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r149382131
--- Diff:
core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala ---
@@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends
MemoryManagerSuite {
override protected def createMemoryManager(
maxOnHeapExecutionMemory: Long,
- maxOffHeapExecutionMemory: Long): StaticMemoryManager = {
+ maxOffHeapExecutionMemory: Long = 1000): StaticMemoryManager = {
new StaticMemoryManager(
conf.clone
.set("spark.memory.fraction", "1")
.set("spark.testing.memory", maxOnHeapExecutionMemory.toString)
- .set("spark.memory.offHeap.size",
maxOffHeapExecutionMemory.toString),
+ .set("spark.memory.offHeap.size",
--- End diff --
How about move the configuration to `internal/config`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
