Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17436#discussion_r149418567 --- Diff: core/src/test/scala/org/apache/spark/memory/StaticMemoryManagerSuite.scala --- @@ -43,12 +43,13 @@ class StaticMemoryManagerSuite extends MemoryManagerSuite { override protected def createMemoryManager( maxOnHeapExecutionMemory: Long, - maxOffHeapExecutionMemory: Long): StaticMemoryManager = { + maxOffHeapExecutionMemory: Long = 1000): StaticMemoryManager = { new StaticMemoryManager( conf.clone .set("spark.memory.fraction", "1") .set("spark.testing.memory", maxOnHeapExecutionMemory.toString) - .set("spark.memory.offHeap.size", maxOffHeapExecutionMemory.toString), + .set("spark.memory.offHeap.size", --- End diff -- To add `= 1000` is intentional and necessary. If the original line is used, `spark.memory.offHeap.size` is zero even in the case `spark.memory.offHeap.enabled == true`. This is because the caller sites do not pass the second argument and then the default value `(= 0)` is used.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org