Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17436#discussion_r150840015
  
    --- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala 
---
    @@ -195,7 +196,7 @@ private[spark] abstract class MemoryManager(
        */
       final val tungstenMemoryMode: MemoryMode = {
         if (conf.getBoolean("spark.memory.offHeap.enabled", false)) {
    --- End diff --
    
    we can move this to the `object config` too


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to