Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19797#discussion_r153973737
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala
 ---
    @@ -164,6 +165,12 @@ class ComplexTypesSuite extends PlanTest{
         comparePlans(Optimizer execute query, expected)
       }
     
    +  test("SPARK-22570: should not create a lot of instance variables") {
    --- End diff --
    
    nit: `Cast should not create a lot of global variables`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to