Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154071162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -110,17 +108,21 @@ private [sql] object GenArrayData {
}
"""
}
+ val assignmentString = ctx.splitExpressions(
+ expressions = assignments,
+ funcName = "apply",
+ extraArguments = ("Object[]", arrayDataName) :: Nil)
- ("",
- assignments,
+ (s"Object[] $arrayName = new Object[$numElements];",
+ assignmentString,
s"final ArrayData $arrayDataName = new
$genericArrayClass($arrayName);",
--- End diff --
to be consistent, shall we also set `arrayName` to null here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
