Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r154073872
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -845,4 +846,11 @@ class CastSuite extends SparkFunSuite with
ExpressionEvalHelper {
val outputOuter = Row.fromSeq((1 to N).map(_ => outputInner))
checkEvaluation(cast(Literal.create(inputOuter, fromOuter), toOuter),
outputOuter)
}
+
+ test("SPARK-22570: Cast should not create a lot of instance variables") {
--- End diff --
nit: instance variables -> global variables. To match with other two added
tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
