Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19854#discussion_r154266308
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala
 ---
    @@ -412,7 +412,9 @@ case class HiveScriptIOSchema (
         propsMap = propsMap + (serdeConstants.LIST_COLUMN_TYPES -> 
columnTypesNames)
     
         val properties = new Properties()
    -    properties.putAll(propsMap.asJava)
    +    // properties.putAll(propsMap.asJava)
    +    // see https://github.com/apache/kafka/pull/3647
    +    propsMap.foreach{ case (k, v) => properties.put(k, v) }
    --- End diff --
    
    And we should not leave commented code.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to