Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19854#discussion_r154266377
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala
 ---
    @@ -424,7 +426,9 @@ case class HiveScriptIOSchema (
         recordReaderClass.map { klass =>
           val instance = 
Utils.classForName(klass).newInstance().asInstanceOf[RecordReader]
           val props = new Properties()
    -      props.putAll(outputSerdeProps.toMap.asJava)
    +      // props.putAll(outputSerdeProps.toMap.asJava)
    +      // see https://github.com/apache/kafka/pull/3647
    --- End diff --
    
    ditto. I think it is better to remove commented code and refer to 
https://github.com/scala/bug/issues/10418.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to