Github user kellyzly commented on a diff in the pull request:
https://github.com/apache/spark/pull/19854#discussion_r155168946
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -169,8 +169,10 @@ public static ByteBuffer allocateDirectBuffer(int
size) {
cleanerField.setAccessible(true);
long memory = allocateMemory(size);
ByteBuffer buffer = (ByteBuffer) constructor.newInstance(memory,
size);
- Cleaner cleaner = Cleaner.create(buffer, () -> freeMemory(memory));
- cleanerField.set(buffer, cleaner);
+// sun.misc.Cleaner is not used in JDK9(see SPARK-22659), we can use
CleanUtil in HADOOP-12760 to solve it
+// Cleaner cleaner = Cleaner.create(buffer, () -> freeMemory(memory));
+// cleanerField.set(buffer, cleaner);
--- End diff --
@srowen ï¼ have deleted changes about Platform.java. So current pr is only
for solving problems met in scala-2.12 and can not fix the problem about JDK9.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
