Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19937#discussion_r155944205
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
 ---
    @@ -617,6 +619,7 @@ case class SortMergeJoinExec(
     
         s"""
            |while (findNextInnerJoinRows($leftInput, $rightInput)) {
    +       |  ${leftVarDecl.mkString("\n")}
    --- End diff --
    
    I think that it is not easy for me to cast to a standalone benchmark since 
generated code depends on the Spark internal structures.  
    I would appreciate it if you would prepare an easy benchmark for you.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to