Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19937#discussion_r155984096
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
 ---
    @@ -513,26 +513,28 @@ case class SortMergeJoinExec(
        * the variables should be declared separately from accessing the 
columns, we can't use the
        * codegen of BoundReference here.
        */
    -  private def createLeftVars(ctx: CodegenContext, leftRow: String): 
Seq[ExprCode] = {
    +  private def createLeftVars(ctx: CodegenContext, leftRow: String): 
(Seq[ExprCode], Seq[String]) = {
    --- End diff --
    
    We need to update the function description. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to