Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19937#discussion_r156000717
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -617,6 +619,7 @@ case class SortMergeJoinExec(
s"""
|while (findNextInnerJoinRows($leftInput, $rightInput)) {
+ | ${leftVarDecl.mkString("\n")}
--- End diff --
Since these local variables are only needed inside the loop, I feel the
current code is more readable. Performance is not a concern here as the
overhead is very low or none.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
