Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19981#discussion_r157581053
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -167,6 +168,24 @@ case class SparkListenerApplicationEnd(time: Long) 
extends SparkListenerEvent
     @DeveloperApi
     case class SparkListenerLogStart(sparkVersion: String) extends 
SparkListenerEvent
     
    +/**
    + * An interface for creating history listeners(to replay event logs) 
defined in other modules like
    + * SQL, and setup the UI of the plugin to rebuild the history UI.
    + */
    +private[spark] trait SparkHistoryUIPlugin {
    --- End diff --
    
    This is not a UI plugin. It's also only marginally related to this source 
file.
    
    It should remain in the `.status` package. If you really feel strongly 
about the existing name, you can use a different name (e.g. 
"AppHistoryServerPlugin" or something that doesn't explicit says "UI" or 
"Listener").


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to