Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157584958
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
---
@@ -36,11 +36,12 @@ import org.apache.spark.sql.catalyst.util.quietly
import org.apache.spark.sql.execution.{LeafExecNode, QueryExecution,
SparkPlanInfo, SQLExecution}
import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics}
import org.apache.spark.sql.test.SharedSQLContext
-import org.apache.spark.status.config._
+import org.apache.spark.status.config.LIVE_ENTITY_UPDATE_PERIOD
import org.apache.spark.util.{AccumulatorMetadata, JsonProtocol,
LongAccumulator}
import org.apache.spark.util.kvstore.InMemoryStore
-class SQLListenerSuite extends SparkFunSuite with SharedSQLContext with
JsonTestUtils {
+
+class SQLAppStatusListenerSuite extends SparkFunSuite with
SharedSQLContext with JsonTestUtils {
--- End diff --
The reason I didn't rename this class is because it contains tests that
have nothing to do with the listener itself (like the test for SPARK-18462),
and doing the proper thing (break those tests out into a separate suite) would
be too noisy for the original change (and would also be pretty noisy here).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
