Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19981#discussion_r157663315
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
 ---
    @@ -36,11 +36,12 @@ import org.apache.spark.sql.catalyst.util.quietly
     import org.apache.spark.sql.execution.{LeafExecNode, QueryExecution, 
SparkPlanInfo, SQLExecution}
     import org.apache.spark.sql.execution.metric.{SQLMetric, SQLMetrics}
     import org.apache.spark.sql.test.SharedSQLContext
    -import org.apache.spark.status.config._
    +import org.apache.spark.status.config.LIVE_ENTITY_UPDATE_PERIOD
     import org.apache.spark.util.{AccumulatorMetadata, JsonProtocol, 
LongAccumulator}
     import org.apache.spark.util.kvstore.InMemoryStore
     
    -class SQLListenerSuite extends SparkFunSuite with SharedSQLContext with 
JsonTestUtils {
    +
    +class SQLAppStatusListenerSuite extends SparkFunSuite with 
SharedSQLContext with JsonTestUtils {
    --- End diff --
    
    Then it's an existing problem of `SQLListenerSuite`, as previously it 
didn't only test `SQLListener`. This should not stop us from renaming it after 
we rename `SQLListener`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to