Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19993#discussion_r158153277
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -430,4 +433,49 @@ object ParamsSuite extends SparkFunSuite {
require(copyReturnType === obj.getClass,
s"${clazz.getName}.copy should return ${clazz.getName} instead of
${copyReturnType.getName}.")
}
+
+ /**
+ * Checks that the class throws an exception in case both `inputCols`
and `inputCol` are set and
+ * in case both `outputCols` and `outputCol` are set.
+ * These checks are performed only whether the class extends
respectively both `HasInputCols` and
+ * `HasInputCol` and both `HasOutputCols` and `HasOutputCol`.
+ *
+ * @param paramsClass The Class to be checked
+ * @param spark A `SparkSession` instance to use
+ */
+ def checkMultiColumnParams(paramsClass: Class[_ <: Params], spark:
SparkSession): Unit = {
--- End diff --
suggestion for function name:
assertColOrCols --> testMultiColumnParams
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
