Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20388#discussion_r163737892
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
    @@ -29,15 +30,15 @@
     
       private final LauncherServer server;
     
    -  private LauncherConnection connection;
    +  private LauncherServer.ServerConnection connection;
       private List<Listener> listeners;
    -  private State state;
    +  private AtomicReference<State> state;
    --- End diff --
    
    What's the rationale behind this? Previously we just make sure all access 
and modification to state is synchronized, are you changing it to 
`AtomicReference` for performance reasons?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to