Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20388#discussion_r163938721
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -104,19 +104,12 @@ void monitorChild() {
ec = 1;
}
- State currState = getState();
- State newState = null;
if (ec != 0) {
+ State currState = getState();
// Override state with failure if the current state is not final,
or is success.
if (!currState.isFinal() || currState == State.FINISHED) {
- newState = State.FAILED;
+ setState(State.FAILED, true);
}
- } else if (!currState.isFinal()) {
- newState = State.LOST;
--- End diff --
This is done by `dispose()` already.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
