Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20388#discussion_r163743052
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -99,8 +100,6 @@ boolean isDisposed() {
*/
synchronized void dispose() {
if (!isDisposed()) {
- // Unregister first to make sure that the connection with the app
has been really
- // terminated.
server.unregister(this);
if (!getState().isFinal()) {
--- End diff --
do we need this `if`? `setState` would do nothing if state is final.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
