Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20422#discussion_r165159188
--- Diff:
core/src/test/scala/org/apache/spark/shuffle/sort/IndexShuffleBlockResolverSuite.scala
---
@@ -133,4 +133,65 @@ class IndexShuffleBlockResolverSuite extends
SparkFunSuite with BeforeAndAfterEa
}
assert(firstByte2(0) === 2)
}
+
+ test("SPARK-23253: index files should be created properly") {
+ val shuffleId = 1
+ val mapId = 2
+ val idxName = s"shuffle_${shuffleId}_${mapId}_0.index"
+ val resolver = new IndexShuffleBlockResolver(conf, blockManager)
+
+ val lengths = (1 to 2).map(_ => 8L).toArray
--- End diff --
you could do `Array.fill(2)(8L)`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
