Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20422#discussion_r165161260
--- Diff:
core/src/test/scala/org/apache/spark/shuffle/sort/IndexShuffleBlockResolverSuite.scala
---
@@ -133,4 +133,65 @@ class IndexShuffleBlockResolverSuite extends
SparkFunSuite with BeforeAndAfterEa
}
assert(firstByte2(0) === 2)
}
+
+ test("SPARK-23253: index files should be created properly") {
--- End diff --
thanks for adding this, but actually I'm not sure this is covering any
cases in the previous test, is it? I was thinking of just adding something to
read the actual index file, and make sure it had the right values to go with
the update to the data file (or no updates in some cases).
you may have added a couple more asserts than the original test -- if so,
maybe they can just be added to the original?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
