Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20422#discussion_r165226127
  
    --- Diff: 
core/src/test/scala/org/apache/spark/shuffle/sort/IndexShuffleBlockResolverSuite.scala
 ---
    @@ -133,4 +133,65 @@ class IndexShuffleBlockResolverSuite extends 
SparkFunSuite with BeforeAndAfterEa
         }
         assert(firstByte2(0) === 2)
       }
    +
    +  test("SPARK-23253: index files should be created properly") {
    --- End diff --
    
    +1 we can add check the index file in the original test case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to