Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20705#discussion_r172024043
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2150,7 +2150,8 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
     
       test("data source table created in InMemoryCatalog should be able to 
read/write") {
         withTable("tbl") {
    -      sql("CREATE TABLE tbl(i INT, j STRING) USING parquet")
    +      val provider = spark.sessionState.conf.defaultDataSourceName
    --- End diff --
    
    This is `SQLQuerySuite`. The test case is correctly testing its 
**purpose**. Every data source have its own capability and limitation. Your 
example is only `text` data source's limitation supporting `a single column 
schema`, isn't it? For the other `csv/json/orc/parquet` will pass this specific 
test.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to