Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20705#discussion_r172024213
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2150,7 +2150,8 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
     
       test("data source table created in InMemoryCatalog should be able to 
read/write") {
         withTable("tbl") {
    -      sql("CREATE TABLE tbl(i INT, j STRING) USING parquet")
    +      val provider = spark.sessionState.conf.defaultDataSourceName
    --- End diff --
    
    So far, the purpose of this PR is **setting once in `SQLConf.scala`** to 
order to test a new data source to find out the limitation instead of 
**touching every data suite**.
    
    BTW, `spark.sql.sources.default=parquet` doesn't help this existing code 
because the SQL has a fixed string `USING parquet`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to