Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20686#discussion_r173584864
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -364,18 +397,26 @@ class QuantileDiscretizerSuite
.setOutputCols(Array("result1", "result2", "result3"))
.setNumBucketsArray(Array(10, 10, 10))
- val result1 = discretizerSingleNumBuckets.fit(df).transform(df)
- .select("result1", "result2", "result3")
- .collect()
- val result2 = discretizerNumBucketsArray.fit(df).transform(df)
- .select("result1", "result2", "result3")
- .collect()
-
- result1.zip(result2).foreach {
- case (row1, row2) =>
- assert(row1.getDouble(0) == row2.getDouble(0) &&
- row1.getDouble(1) == row2.getDouble(1) &&
- row1.getDouble(2) == row2.getDouble(2))
+ val model = discretizerSingleNumBuckets.fit(df)
+ val expected = model.transform(df).select("result1", "result2",
"result3").collect()
+
+
+ testTransformerByGlobalCheckFunc[(Double, Double, Double)](
+ df,
+ model,
+ "result1",
+ "result2",
+ "result3") { rows =>
+ assert(rows === expected)
+ }
+
+ testTransformerByGlobalCheckFunc[(Double, Double, Double)](
--- End diff --
Is this a repeat of the test just above?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
