Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20858#discussion_r176901684
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
 ---
    @@ -699,3 +699,88 @@ abstract class TernaryExpression extends Expression {
      * and Hive function wrappers.
      */
     trait UserDefinedExpression
    +
    +/**
    + * The trait covers logic for performing null save evaluation and code 
generation.
    + */
    +trait NullSafeEvaluation extends Expression
    --- End diff --
    
    Do we need to bring in `NullSafeEvaluation`? If only `ConcatArray` uses it, 
we may not need to add this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to