Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20858#discussion_r176966017
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -3046,6 +3046,14 @@ object functions {
         ArrayContains(column.expr, Literal(value))
       }
     
    +  /**
    +   * Merges multiple arrays into one by putting elements from the specific 
array after elements
    +   * from the previous array. If any of the arrays is null, null is 
returned.
    +   * @group collection_funcs
    +   * @since 2.4.0
    +   */
    +  def concat_arrays(columns: Column*): Column = withExpr { 
ConcatArrays(columns.map(_.expr)) }
    --- End diff --
    
    We need to add this func. in `sql/functions` here? It seems we might 
recommend users to use these kinds of functions via `selectExpr`, so is it okay 
to add this only in `FunctionRegistry`? Thoughts? @viirya @gatorsmile 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to