Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20858#discussion_r176971799
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -287,3 +289,152 @@ case class ArrayContains(left: Expression, right: 
Expression)
     
       override def prettyName: String = "array_contains"
     }
    +
    +/**
    + * Concatenates multiple arrays into one.
    + */
    +@ExpressionDescription(
    +  usage = "_FUNC_(expr, ...) - Concatenates multiple arrays into one.",
    +  examples = """
    +    Examples:
    +      > SELECT _FUNC_(array(1, 2, 3), array(4, 5), array(6));
    +       [1,2,3,4,5,6]
    +  """)
    +case class ConcatArrays(children: Seq[Expression]) extends Expression with 
NullSafeEvaluation {
    --- End diff --
    
    Can we add a common base class (e.g., `ConcatLike`) for handling nested 
`ConcatArrays` in the optimizer(`CombineConcat`)?
    
    
https://github.com/apache/spark/blob/e4bec7cb88b9ee63f8497e3f9e0ab0bfa5d5a77c/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala#L649


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to