Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179832847
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -99,17 +100,27 @@
*/
private boolean allowsMixedArguments;
+ /**
+ * This constructor is used when creating a user-configurable launcher.
It allows the
+ * spark-submit argument list to be modified after creation.
+ */
SparkSubmitCommandBuilder() {
- this.sparkArgs = new ArrayList<>();
this.isAppResourceReq = true;
this.isExample = false;
+ this.parsedArgs = new ArrayList<>();
+ this.userArgs = new ArrayList<>();
}
+ /**
+ * This constructor is used when invoking spark-submit; it parses and
validates arguments
+ * provided by the user on the command line.
+ */
SparkSubmitCommandBuilder(List<String> args) {
this.allowsMixedArguments = false;
- this.sparkArgs = new ArrayList<>();
+ this.parsedArgs = new ArrayList<>();
boolean isExample = false;
List<String> submitArgs = args;
+ this.userArgs = null;
--- End diff --
Consider Collections.emptyList(). I see these two constructors covers two
different use cases. An abstract base class with two derived classes could
express this two uses cases better but I know it is out of scope for now. Does
it make sense to create a Jira ticket for refactoring this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
