Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179892170
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -88,7 +88,8 @@
SparkLauncher.NO_RESOURCE);
}
- final List<String> sparkArgs;
+ final List<String> userArgs;
--- End diff --
That's overkill for final fields. Even more if those fields are
package-private.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
