Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20925#discussion_r179892080
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -499,20 +497,18 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
}
private def printUsageAndExit(exitCode: Int, unknownParam: Any = null):
Unit = {
--- End diff --
The intent is to "exit" the submission process (even if there's no "exit"
in some cases). The different name would also feel weird given the "exitCode"
parameter. So even if not optimal I prefer the current name.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
