Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21133#discussion_r184658151
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
---
@@ -279,4 +282,11 @@ class ApproximatePercentileQuerySuite extends
QueryTest with SharedSQLContext {
checkAnswer(query, expected)
}
}
+
+ test("SPARK-24013: unneeded compress can cause performance issues with
sorted input") {
+ failAfter(30 seconds) {
+ checkAnswer(sql("select approx_percentile(id, array(0.1)) from
range(10000000)"),
+ Row(Array(999160)))
--- End diff --
it is not the only place where it is checked with an exact answer, so I
don't think it is an issue, a small change would anyway require to change many
test cases answers. What do you think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
