Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21133#discussion_r184868808
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
---
@@ -279,4 +282,11 @@ class ApproximatePercentileQuerySuite extends
QueryTest with SharedSQLContext {
checkAnswer(query, expected)
}
}
+
+ test("SPARK-24013: unneeded compress can cause performance issues with
sorted input") {
+ failAfter(30 seconds) {
--- End diff --
We can add a UT for `ApproximatePercentile`, and check that after calling
`add`, `isCompressed` is still false.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
