Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21133#discussion_r184866940 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala --- @@ -238,12 +238,6 @@ object ApproximatePercentile { summaries = summaries.insert(value) // The result of QuantileSummaries.insert is un-compressed isCompressed = false --- End diff -- I think so, since we still compress in many places: in `merge`, `getPercentiles` and in `quantileSummaries`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org