Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21413#discussion_r190415802
  
    --- Diff: python/pyspark/ml/regression.py ---
    @@ -619,6 +627,20 @@ def getSubsamplingRate(self):
             """
             return self.getOrDefault(self.subsamplingRate)
     
    +    @since("1.4.0")
    +    def setFeatureSubsetStrategy(self, value):
    --- End diff --
    
    this method should be in the GBT/RandomForest estimator classes 
(classification and regression) and the old method in RandomForestParams should 
be deprecated, would you mind doing this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to