Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21413#discussion_r190650505
--- Diff: python/pyspark/ml/regression.py ---
@@ -619,6 +627,20 @@ def getSubsamplingRate(self):
"""
return self.getOrDefault(self.subsamplingRate)
+ @since("1.4.0")
+ def setFeatureSubsetStrategy(self, value):
--- End diff --
`setFeatureSubsetStrategy` should only be in the GBT/RF estimators, while
`getFeatureSubsetStrategy` can be in `TreeEnsembleParams` so it is inherited by
both the estimators and models. It's because we don't want methods to set
training params in the Model classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
