Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21413#discussion_r190638735
--- Diff: python/pyspark/ml/regression.py ---
@@ -619,6 +627,20 @@ def getSubsamplingRate(self):
"""
return self.getOrDefault(self.subsamplingRate)
+ @since("1.4.0")
+ def setFeatureSubsetStrategy(self, value):
--- End diff --
@BryanCutler Thanks for your review. I will modify the code. One question:
Shall I only put the ```setFeatureSubsetStrategy``` in GBT/RandomForest? or put
both the setter and getter? I looked the ml python code, it seems to me that
the getter and setter are always in pairs.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
