Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20915#discussion_r192953104
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
---
@@ -50,6 +51,84 @@ import org.apache.spark.sql.execution.SparkPlan
* and add it. Proceed to the next file.
*/
object FileSourceStrategy extends Strategy with Logging {
+
+ // should prune buckets iff num buckets is greater than 1 and there is
only one bucket column
+ private def shouldPruneBuckets(bucketSpec: Option[BucketSpec]): Boolean
= {
+ bucketSpec match {
+ case Some(spec) => spec.bucketColumnNames.length == 1 &&
spec.numBuckets > 1
+ case None => false
+ }
+ }
+
+ private def getExpressionBuckets(expr: Expression,
--- End diff --
nit: code style
```
def xxx(
para1: A,
para2: B): XXX
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
