Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20915#discussion_r192953858
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala
 ---
    @@ -79,6 +158,13 @@ object FileSourceStrategy extends Strategy with Logging 
{
             
ExpressionSet(normalizedFilters.filter(_.references.subsetOf(partitionSet)))
           logInfo(s"Pruning directories with: 
${partitionKeyFilters.mkString(",")}")
     
    +      val bucketSpec: Option[BucketSpec] = fsRelation.bucketSpec
    +      val bucketSet = if (shouldPruneBuckets(bucketSpec)) {
    +        getBuckets(normalizedFilters, bucketSpec.get)
    --- End diff --
    
    nit: maybe better to call it `genBucketSet` instead of `getBuckets`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to