Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20915#discussion_r192953873
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -83,39 +88,43 @@ abstract class BucketedReadSuite extends QueryTest with
SQLTestUtils {
// To verify if the bucket pruning works, this function checks two
conditions:
// 1) Check if the pruned buckets (before filtering) are empty.
// 2) Verify the final result is the same as the expected one
- private def checkPrunedAnswers(
- bucketSpec: BucketSpec,
- bucketValues: Seq[Integer],
- filterCondition: Column,
- originalDataFrame: DataFrame): Unit = {
+ private def checkPrunedAnswers(bucketSpec: BucketSpec,
--- End diff --
nit: code style
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
