Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22236#discussion_r213523669
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala ---
    @@ -116,6 +135,9 @@ object AssociationRules {
         @Since("1.5.0")
         def confidence: Double = freqUnion.toDouble / freqAntecedent
    --- End diff --
    
    I suppose this `.toDouble` is redundant actually!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to