Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22236#discussion_r213523645 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/AssociationRules.scala --- @@ -107,7 +125,8 @@ object AssociationRules { @Since("1.5.0") val antecedent: Array[Item], @Since("1.5.0") val consequent: Array[Item], freqUnion: Double, - freqAntecedent: Double) extends Serializable { + freqAntecedent: Double, --- End diff -- Ideally these frequencies would have been Longs I think, but too late. Yes, stay consistent.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org