Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22236#discussion_r213571991
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -187,7 +191,8 @@ class FPGrowth @Since("2.2.0") (
           items.unpersist()
         }
     
    -    copyValues(new FPGrowthModel(uid, frequentItems)).setParent(this)
    +    copyValues(new FPGrowthModel(uid, frequentItems, 
parentModel.itemSupport, inputRowCount))
    --- End diff --
    
    Well, there is no way to know the total size of the training dataset from 
the frequent itemsets unfortunately... So yes, we need to deal with it 
unfortunately.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to