Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22337#discussion_r216033251
--- Diff:
external/kafka-0-8/src/test/scala/org/apache/spark/streaming/kafka/KafkaRDDSuite.scala
---
@@ -35,20 +35,25 @@ class KafkaRDDSuite extends SparkFunSuite with
BeforeAndAfterAll {
private var sc: SparkContext = _
override def beforeAll {
+ super.beforeAll()
sc = new SparkContext(sparkConf)
kafkaTestUtils = new KafkaTestUtils
kafkaTestUtils.setup()
}
override def afterAll {
- if (sc != null) {
- sc.stop
- sc = null
- }
+ try {
+ if (sc != null) {
+ sc.stop
+ sc = null
+ }
- if (kafkaTestUtils != null) {
- kafkaTestUtils.teardown()
- kafkaTestUtils = null
+ if (kafkaTestUtils != null) {
+ kafkaTestUtils.teardown()
+ kafkaTestUtils = null
+ }
+ } finally {
+ super.afterAll()
--- End diff --
@kiszk Can sc.stop throw an exception ? If so, shouldn't we attempt to do a
teardown first before calling super.afterAll() ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
