Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22337#discussion_r216034900
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala
---
@@ -49,8 +49,11 @@ class StateStoreRDDSuite extends SparkFunSuite with
BeforeAndAfter with BeforeAn
}
override def afterAll(): Unit = {
- super.afterAll()
- Utils.deleteRecursively(new File(tempDir))
+ try {
+ Utils.deleteRecursively(new File(tempDir))
+ } finally {
+ super.afterAll()
--- End diff --
I prefer your change, too. But, the reason why I asked is that you didn't
fix the order in
[FlatMapGroupsWithStateSuite](https://github.com/apache/spark/pull/22337/files#diff-1e4641593c1f96a15e4502b1e53e721eR57)
in this PR. I want to make it sure whether there is a obvious reason or not.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
