Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22192#discussion_r216106482 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -219,6 +239,18 @@ private[spark] class Executor( heartbeater.shutdown() heartbeater.awaitTermination(10, TimeUnit.SECONDS) threadPool.shutdown() + + // Notify plugins that executor is shutting down so they can terminate cleanly + Utils.withContextClassLoader(replClassLoader) { + plugins.foreach(plugin => { + try { + plugin.shutdown() + } catch { + case e: Exception => + logWarning(s"Plugin ${plugin.getClass} failed to shutdown: ${e.getMessage()}") --- End diff -- Log the whole exception, not just the message.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org