Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r216116705
--- Diff: core/src/test/java/org/apache/spark/ExecutorPluginSuite.java ---
@@ -68,7 +68,9 @@ public void testPluginClassDoesNotExist() {
} catch (Exception e) {
// We cannot catch ClassNotFoundException directly because Java
doesn't think it'll be thrown
assertTrue(e.toString().startsWith("java.lang.ClassNotFoundException"));
+ return;
--- End diff --
You can avoid this by having the `fail` inside the `try` block.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
