Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22192#discussion_r216116693
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -242,14 +242,17 @@ private[spark] class Executor(
     
         // Notify plugins that executor is shutting down so they can terminate 
cleanly
         Utils.withContextClassLoader(replClassLoader) {
    -      plugins.foreach(plugin => {
    +      executorPlugins.foreach { plugin =>
             try {
               plugin.shutdown()
             } catch {
               case e: Exception =>
    -            logWarning(s"Plugin ${plugin.getClass} failed to shutdown: 
${e.getMessage()}")
    +            logWarning(
    +              s"""Plugin ${plugin.getClass().getCanonicalName()} failed to 
shutdown:
    +                 |${e.toString}
    --- End diff --
    
    You can just use `logWarning("Msg", e)` to log the whole thing...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to